Initial C Bindings for Cosmos DB SDK for Rust #3347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Azure.Core
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
analogrelay
commented
Nov 14, 2025
analogrelay
force-pushed
the
ashleyst/port-c-bindings
branch
from
4393c1b to
aeaba92
Compare
analogrelay
changed the title
Copilot finished reviewing on behalf of
analogrelay
November 20, 2025 00:04
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces C bindings for the Azure Cosmos DB SDK for Rust, allowing the SDK to be used from C and other languages. Key changes include:
- New FFI layer with runtime context, call context, and error handling infrastructure
- C bindings for CosmosClient, DatabaseClient, and ContainerClient
- Support for CRUD operations, queries, and resource management
- Auto-generated C header file (
azurecosmos.h) - Comprehensive C test suite covering CRUD operations, error handling, and memory management
Reviewed Changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/string.rs |
String utilities and FFI string conversion helpers |
src/runtime/tokio.rs |
Tokio runtime wrapper for async operations |
src/runtime/mod.rs |
Runtime context FFI functions |
src/options/mod.rs |
Empty option structs for future extensibility |
src/lib.rs |
Main library entry, version function, and tracing setup |
src/error.rs |
Error types, codes, and conversion from Azure SDK errors |
src/context.rs |
Call context for FFI operations and helper macros |
src/clients/mod.rs |
Client module exports |
src/clients/database_client.rs |
Database operations FFI functions |
src/clients/cosmos_client.rs |
Cosmos client creation and database operations |
src/clients/container_client.rs |
Container and item operations FFI functions |
include/azurecosmos.h |
Auto-generated C header file |
c_tests/*.c |
C test suite for FFI functionality |
build.rs |
cbindgen configuration for header generation |
Cargo.toml |
Dependencies and features for native bindings |
CMakeLists.txt |
CMake build configuration for C tests |
Comments suppressed due to low confidence (1)
sdk/cosmos/azure_data_cosmos_native/src/string.rs:37
- The
safe_cstring_newfunction callsexpect()which can panic, but this panic behavior is not documented. Add a# Panicssection to the function documentation explaining when this function panics (when the string contains interior NUL bytes).
sdk/cosmos/azure_data_cosmos_native/src/clients/container_client.rs
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure_data_cosmos_native/c_tests/context_memory_management.c
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports over the initial C bindings, contributed by a partner team, to this repository.
The bindings are defined in the
azure_data_cosmos_nativecrate, which buildslibazurecosmos.aandlibazurecosmos.so(and others on other platforms). That project also creates theazurecosmos.hheader file.